Repository navigation
test(cli): build expected codex path with path.join for Windows - #1803
Open
leucds2018-hub wants to merge 1 commit into
Open
leucds2018-hub wants to merge 1 commit into
leucds2018-hub wants to merge 1 commit into
Conversation
detect.test.ts asserted a POSIX literal ('/opt/tools/bin/codex') while executableOnPath joins PATH entries with the host separator, so the test failed on Windows with received '\opt\tools\bin\codex'.
Assert the path the same way the implementation builds it, so the suite is green on both separators.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cli/src/detect.test.tsasserts a POSIX literal:but
executableOnPathbuilds the candidate withpath.join(dir, name), which uses the host separator. On Windows the test fails:The implementation is correct —
path.joinis the right call at runtime — so only the assertion is platform-specific. Effect:npm testfails for Windows contributors in thecliworkspace (178/179) even though the server suite is green, which makes the documented "keep the suite green" checklist impossible to satisfy locally.Fix
Assert the path the same way the implementation builds it:
path.posix.join(...)would also pass, but it pins the assertion to the opposite separator and would break again if the implementation changed, so joining with the hostpathis the accurate choice.Verification
npx vitest runincli/on Windows 11: 179/179 passing (was 178/179)npm run build(root): OKnpm test -w server: green